Skip to content

K8s: fix ingress doc bugs#3351

Open
kaitlynmichael wants to merge 3 commits into
mainfrom
ngnx-issue
Open

K8s: fix ingress doc bugs#3351
kaitlynmichael wants to merge 3 commits into
mainfrom
ngnx-issue

Conversation

@kaitlynmichael
Copy link
Copy Markdown
Contributor

@kaitlynmichael kaitlynmichael commented May 20, 2026

Note

Low Risk
Documentation-only changes with no application code; risk is limited to readers following updated hostname or ingress configuration examples.

Overview
This PR updates Redis Enterprise for Kubernetes networking and Active-Active documentation across versioned (7.4.6, 7.8.x, 7.22) and unversioned paths, plus embedded RERC YAML samples.

Ingress-NGINX: Adds prominent warnings that the community kubernetes/ingress-nginx controller is retired (maintenance ended March 2026). Docs now steer new deployments toward HAProxy or Istio (and mention Gateway API on some pages), while listing Ingress-NGINX only for existing deployments with --enable-ssl-passthrough called out.

Ingress resource examples: Sample Ingress manifests now use spec.ingressClassName instead of documenting kubernetes.io/ingress.class on the Ingress rule; HAProxy/NGINX examples drop redundant ingress.class annotations and keep ssl-passthrough annotations only.

Istio: Gateway examples change port protocol/name from HTTPS to TLS for passthrough on 443, and the default gateway selector is documented as istio: ingressgateway.

Active-Active / RERC: dbFqdnSuffix in embeds and several Active-Active guides switches from a leading hyphen (e.g. -db-...) to a leading dot (e.g. .db-...). Unversioned ingressorroutespec aligns REC patch examples and hostname explanation with .db-<rec>-<ns>.<domain> and how the operator concatenates database names.

ingressOrRouteSpec: Clarifies DNS naming, fixes kubectl patch JSON (including kubernetes.io/ingress.class in examples), and notes operator validation for that annotation key.

Minor: Networking index blurbs and database-connectivity controller lists updated; previous K8s release-notes index weight 91100.

Reviewed by Cursor Bugbot for commit 0dfb7c1. Bugbot is set up for automated code reviews on this repo. Configure here.

@kaitlynmichael kaitlynmichael requested a review from a team May 20, 2026 20:27
@kaitlynmichael kaitlynmichael self-assigned this May 20, 2026
@kaitlynmichael kaitlynmichael added bug Something isn't working k8s labels May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Staging links:
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.22/active-active/create-reaadb
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.22/networking/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.22/networking/database-connectivity/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.22/networking/ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.22/networking/ingressorroutespec/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.22/networking/istio-ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.22/reference/yaml/active-active
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.4.6/networking/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.4.6/networking/ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.4.6/networking/ingressorroutespec/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.4.6/networking/istio-ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.4/networking/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.4/networking/ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.4/networking/ingressorroutespec/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.4/networking/istio-ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.6/networking/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.6/networking/ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.6/networking/ingressorroutespec/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/7.8.6/networking/istio-ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/8.0.18/active-active/create-reaadb
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/8.0.18/reference/yaml/active-active
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/8.0/active-active/create-reaadb
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/8.0/reference/yaml/active-active
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/active-active/create-reaadb
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/active-active/create-reaadb/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/active-active/edit-clusters/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/active-active/edit-rerc/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/active-active/prepare-clusters/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/networking/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/networking/database-connectivity/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/networking/ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/networking/ingressorroutespec/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/networking/istio-ingress/
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/reference/yaml/active-active
https://redis.io/docs/staging/ngnx-issue/operate/kubernetes/release-notes/previous-releases/

@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 20, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Copy link
Copy Markdown
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language LGTM.

@kaitlynmichael kaitlynmichael requested a review from yuvallevy2 May 21, 2026 16:30
An Ingress is an API resource that provides a standardized and flexible way to manage external access to services running within a Kubernetes cluster.

{{<warning>}}
The community [Ingress-NGINX controller](https://github.com/kubernetes/ingress-nginx) (`kubernetes/ingress-nginx`) is retired. Best-effort maintenance ended in March 2026 and the project no longer ships releases, bug fixes, or security updates. If you are not already using it, use HAProxy or Istio, or migrate to a [Gateway API](https://gateway-api.sigs.k8s.io/) implementation.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mention of Gateway API here is not really relevant, because the RE operator doesn't yet support Gateway API; Specifically in the context of this page, which is about how to configure the operator to automatically set up Ingress objects for DBs/RS API - we don't have such automation for Gateway API setup.

Comment on lines +32 to +36
We recommend using a wildcard (`*`) in place of the database name, followed by the hostname suffix.
The operator appends each database name to `dbFqdnSuffix` to build the per-database hostname. For example, a database named `mydb` with the suffix above resolves to `mydb-db-<rec-name>-<rec-namespace>.<subdomain>`. For the wildcard DNS record, use `*` in place of the database name followed by the suffix.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our suggestion to use wildcards, combined with the example suffixes (-db-<rec-name>-<rec-namespace>.<subdomain>), yield DNS records which are generally invalid - wildcards can only be full labels. This may work with some DNS providers, but is still invalid per the RFC.

So:

  • Invalid: *-db-<rec-name>-<rec-namespace>.<subdomain>
  • Valid: *.db-<rec-name>-<rec-namespace>.<subdomain>

We should probably revise our example suffixes to be .db-<rec-name>-<rec-namespace>.<subdomain>.
You already addressed something kinda similar in #2327, but that was in the context of Istio ingress only.

This appears both in the old and new phrasing, so not directly related to this PR ==> can be handled later.

@kaitlynmichael kaitlynmichael requested a review from zcahana June 4, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working k8s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants